[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Olivier Guilyardi]

Attached: jack demuxer patch 0.12

Diego Biurrun wrote:
> On Tue, Mar 17, 2009 at 02:11:07PM +0100, Olivier Guilyardi wrote:
>> Diego Biurrun wrote:
>>> On Tue, Mar 17, 2009 at 12:40:13PM +0100, Olivier Guilyardi wrote:
>>>> Diego Biurrun wrote:
>>>>> A changelog and docs update is missing.
>>>> Done for the changelog, but which docs are you talking about?
>>> doc/general.texi
>> There's nothing about devices in there. Neither about oss, alsa, v4l, etc...
> 
> Now there is.

Alright, JACK device added in general.texi

> 
>> Plus if this is really about documenting, the presentation/structure of
>> general.texi doesn't fit the job IMO. The one thing that is important to
>> document is that the input "filename" must be the jack client name. I don't see
>> where to put that in the layout of general.texi.
> 
> Is that already in a source comment?

Now it is, near jack_client_open()

>>>> --- Changelog	(revision 18021)
>>>> +++ Changelog	(working copy)
>>>> @@ -4,6 +4,7 @@
>>>>  - deprecated vhook subsystem removed
>>>>  - deprecated old scaler removed
>>>>  - VQF demuxer
>>>> +- JACK demuxer
>>> Maybe you could write "JACK device demuxer" or similar to differentiate
>>> this from file demuxers?  The entry for ALSA reads
>>>
>>>   - ALSA support for playback and record
>> "Record" isn't the right word here IMO. You might be reading audio data from
>> alsa and streaming it live, thus not recording anything.
>>
>> What about "JACK Audio Connection Kit input device"?
>> Or the simpler (a bit obscure though) "JACK input device"?
> 
> both fine

Corrected to "JACK Audio Connection Kit input device"

--
  Olivier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-r18038-jack-0.12.patch
Type: text/x-patch
Size: 15013 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090319/81cdc7aa/attachment.bin>