[FFmpeg-devel] [PATCH] Do not assume long is same width as x86 register in swscale.

[Michael Niedermayer]

On Mon, Mar 16, 2009 at 05:18:45PM -0300, Ramiro Polla wrote:
> Hi,
> 
> On Tue, Jan 27, 2009 at 7:49 PM, Reimar D?ffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > On Tue, Jan 27, 2009 at 08:13:56PM -0200, Ramiro Polla wrote:
> >> On Tue, Jan 27, 2009 at 6:08 PM, Reimar D?ffinger
> >> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> >> > I think I sent a more extensive patch for that, I just never got around
> >> > to test it properly (regression tests were always failing for me back
> >> > then), you should be able to find it in the archives...
> >>
> >> The only patch I can remember is this one:
> >> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/76182
> >
> > I meant the one: [FFmpeg-devel] [PATCH] use x86_reg in libswscale
> > on Sun, 2 Nov 2008 20:40:40 +0100
> 
> Sorry for the delay, but I was caught up with the regression test
> failures you mentioned.
> 
> Regression tests for mingw-w64 now pass with --disable-optimizations,
> the strtod() hack, and the printf() hack for seek tests. To
> --enable-gpl, updated patch must be applied, and the tests pass.
> 
> swscale-example crashes on funnyYCode (couldn't there be a better name
> for this?). I'll look further later but I'm guessing it has something
> to do with the OS not allowing malloc'd code to run.


[...]
> Index: libswscale/swscale-example.c
> ===================================================================
> --- libswscale/swscale-example.c	(revision 28974)
> +++ libswscale/swscale-example.c	(working copy)
> @@ -199,7 +199,7 @@
>  
>      for (y=0; y<H; y++){
>          for (x=0; x<W*4; x++){
> -            rgb_data[ x + y*4*W]= random();
> +            rgb_data[ x + y*4*W]= rand();
>          }
>      }
>      sws_scale(sws, rgb_src, rgb_stride, 0, H, src, stride);

no
we have our own PRNG


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090317/78bd6f8f/attachment.pgp>