[FFmpeg-devel] [PATCH] Implement AVPixFmtDescriptor.name

[Stefano Sabatini]

On date Sunday 2009-03-15 02:04:26 +0100, Michael Niedermayer encoded:
> On Sun, Mar 15, 2009 at 12:50:15AM +0100, Stefano Sabatini wrote:
> > Hi,
> > 
> > as in subject.
> [...]
> > Index: ffmpeg/libavcodec/pixdesc.h
> > ===================================================================
> > --- ffmpeg.orig/libavcodec/pixdesc.h	2009-03-15 00:43:36.000000000 +0100
> > +++ ffmpeg/libavcodec/pixdesc.h	2009-03-15 00:43:53.000000000 +0100
> > @@ -41,6 +41,7 @@
> >   *       are stored not what these values represent.
> >   */
> >  typedef struct AVPixFmtDescriptor{
> > +    const char *name;
> 
> const char name[10];

I feel uncomfortable with just 10 chars, what about to raise that size
to 16 or more?

Then we won't need bump in case of some overly long pixfmts, and we
have *already* pixfmt names which can't be contained in 10 chars
("vaapi_moco").
 
> one pointer less (4-8 byte) and its doesnt need relocations in PICs, thus
> is easier to share ...

Regards.
-- 
FFmpeg = Freak & Frenzy Magic Purposeless Elitist Gadget