[FFmpeg-devel] [PATCH] Add hwaccel_context to AVCodecContext

[Michael Niedermayer]

On Wed, Mar 11, 2009 at 11:15:06PM +0100, Gwenole Beauchesne wrote:
> Hi,
>
> This adds an hwaccel_context variable to AVCodecContext. It's used to hold 
> read-only data from an FFmpeg point-of-view. Typically, those are HW 
> accelerator data.
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 1042438..a98b247 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -2340,6 +2340,13 @@ typedef struct AVCodecContext {
>       * Set to time_base ticks per frame. Default 1, e.g., H.264/MPEG-2 set it to 2.
>       */
>      int ticks_per_frame;
> +
> +    /**
> +     * Hardware accelerator context. This variable holds read-only data from an FFmpeg point of view.
> +     * - encoding: unused
> +     * - decoding: Set by user
> +     */
> +    const void *hwaccel_context;
>  } AVCodecContext;

This is not acceptable, this is not specifiying anything at all
not who sets it not when no details
just some void * set by the user but set to what? can he set it to
"foobar" ?
thats not a documentation of an API

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090312/1b199eb0/attachment.pgp>