[FFmpeg-devel] [PATCH] swscale alpha channel support

Michael Niedermayer michaelni
Tue Mar 10 22:26:58 CET 2009


On Tue, Mar 10, 2009 at 09:02:28PM +0100, Benoit Fouet wrote:
> Michael Niedermayer wrote :
> > On Tue, Mar 10, 2009 at 06:06:09PM +0000, M?ns Rullg?rd wrote:
> >   
> >> Carl Eugen Hoyos <cehoyos at ag.or.at> writes:
> >>
> >>     
> >>> M?ns Rullg?rd <mans <at> mansr.com> writes:
> >>>
> >>>       
> >>>>> +  echo "  --enable-swscale-alpha  enable alpha channel support in swscale"
> >>>>>           
> >>> What is bad about alpha channel support in swscale?
> >>> (Why would somebody want it disabled?)
> >>>       
> >> Apparently it slows down the non-alpha paths ever so slightly.
> >>     
> >
> > also it adds more code ...
> > IMHO it would be best if all pixfmts could be disabled individually
> >
> >   
> 
> how would you think it would be better to disable them ?
>  - disable a pixel format entirely ?
>  - disable a pixel format as source format ?
>  - disable a pixel format as a dest format ?
>  - the two latter above ?

Id take what (patch) i get

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090310/ff4e691c/attachment.pgp>



More information about the ffmpeg-devel mailing list