[FFmpeg-devel] [RFC] TwinVQ decoder

[Aurelien Jacobs]

On Sat, 7 Mar 2009 19:45:09 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> On Sat, Mar 07, 2009 at 05:47:51PM +0100, Vitor Sessak wrote:
> > [...]
> > typedef struct {
> >     const FrameMode fmode[3];
> > 
> >     uint16_t  n_fr;
> >     uint8_t   n_pr;
> >     const float *lspcodebook;
> >     uint8_t   lsp_bit0;
> >     uint8_t   lsp_bit1;
> >     uint8_t   lsp_bit2;
> >     uint8_t   lsp_split;
> >     const float *pit_cb;
> >     uint8_t   basf_bit;
> >     uint8_t   pit_n_bit;
> >     uint8_t   pit_cb_len;
> >     uint8_t   pgain_bit;
> > } ModeTab;
> 
> I don't like typedefs :)

I like typedefs...

Oh, and I can't belive you missed the following:

> Index: libavcodec/allcodecs.c
> ===================================================================
> --- libavcodec/allcodecs.c	(revision 17855)
> +++ libavcodec/allcodecs.c	(working copy)
> @@ -213,6 +213,7 @@
>      REGISTER_DECODER (TTA, tta);
>      REGISTER_DECODER (VMDAUDIO, vmdaudio);
>      REGISTER_ENCDEC  (VORBIS, vorbis);
> +    REGISTER_DECODER (TWINVQ, twinvq);
>      REGISTER_DECODER (WAVPACK, wavpack);
>      REGISTER_ENCDEC  (WMAV1, wmav1);
>      REGISTER_ENCDEC  (WMAV2, wmav2);

Sorting...

Aurel