[FFmpeg-devel] [PATCH] read header in FLAC demuxer

[Justin Ruggles]

Justin Ruggles wrote:
> Michael Niedermayer wrote:
>> On Mon, Feb 02, 2009 at 09:00:05PM -0500, Justin Ruggles wrote:
>>> I'm open to suggestions or other samples to test.
>> what you tested sounds good
>> in addition you could test if -acodec copy to containers supporting flac
>> result in identical files
> 
> Good idea. I'll test some, then submit the new patch.

Now that the FLAC muxer has changed, this patch is somewhat simpler.  It
still disallows the header to be passed to the decoder with frame data,
but that is not needed by any of our demuxers after this patch.  One
thing I'm unsure of is whether or not to bump the lavc minor version
since the FLAC decoder behavior will change.

As for "-acodec copy", the only thing that will change is that remuxing
from raw FLAC to wav or avi will put the STREAMINFO in WAVEFORMATEX like
it should instead of in the data.  Remuxing raw FLAC to other containers
is still broken because we don't have a FLAC parser.

And I know I maintain both of these files now, but this is a large piece
of code that I think should pass review before I commit it.

Thanks,
Justin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: flac_read_header_12.diff
Type: text/x-diff
Size: 8366 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090228/c0718032/attachment.diff>