[FFmpeg-devel] [PATCH] simplify slice_end

[Michael Niedermayer]

On Mon, Jun 29, 2009 at 05:44:20PM -0700, Baptiste Coudurier wrote:
> Hi,
> 
> $subject.
> 
> -- 
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> FFmpeg maintainer                                  http://www.ffmpeg.org

>  mpeg12.c |   15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 498815a334b24cc024a4953600cca4e37530d2a5  mpeg12_dec_simplify_slice_end.patch
> diff --git a/libavcodec/mpeg12.c b/libavcodec/mpeg12.c
> index 477e99c..f21d8c5 100644
> --- a/libavcodec/mpeg12.c
> +++ b/libavcodec/mpeg12.c
> @@ -1937,13 +1937,13 @@ static int slice_decode_thread(AVCodecContext *c, void *arg){
>   * Handles slice ends.
>   * @return 1 if it seems to be the last slice
>   */
> -static int slice_end(AVCodecContext *avctx, AVFrame *pict)
> +static void slice_end(AVCodecContext *avctx, AVFrame *pict, int *data_size)

i prefer *data_size= slice_end() over slice_end(data_size), it makes it
more explicit what is returned

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090630/18ff696e/attachment.pgp>