[FFmpeg-devel] What is the relationship between wmv1, wmv2 and wmv3 and msmpeg4?

[Diego Biurrun]

On Sun, Jun 28, 2009 at 06:23:08PM +0200, Stefan Gehrer wrote:
> 
> Updated patch for today's SVN attached.

Changelog and documentation updates are missing.

> --- libavcodec/cavsenc.c	(revision 0)
> +++ libavcodec/cavsenc.c	(revision 0)
> @@ -0,0 +1,687 @@

Please use K&R style for new files.

> +/**
> + * @file cavsenc.c

libavcodec/ prefix

> +/*
> + * taken from AVS paper by Lu Yu/Feng Yi/Jie Dong/Cixun Zhang
> + * this is used to post-normalise the rounding errors of the
> + * forward transform in the encoder as well as pre-normalise the
> + * rounding errors of the inverse transform in the decoder,
> + * both due to using non-orthogonal integer matrices

Please use proper punctuation and capitalization, it makes your text
easier to read.

> +static int cavs_encode_frame(AVCodecContext *avctx, unsigned char *buf, int buf_size, void *data){

nit: long line, same in other places

> +static int cavs_encode_init(AVCodecContext * avctx) {

av_cold

> +AVCodec cavs_encoder = {
> +    "cavs",
> +    CODEC_TYPE_VIDEO,
> +    CODEC_ID_CAVS,
> +    sizeof(AVSContext),
> +    cavs_encode_init,
> +    cavs_encode_frame,
> +    ff_cavs_end,
> +};

long_name is missing.

Diego