[FFmpeg-devel] [PATCH] Frame erasure case of pitch delay decoding

[Vladimir Voroshilov]

2009/6/29 Michael Niedermayer <michaelni at gmx.at>:
> On Mon, Jun 29, 2009 at 05:41:48AM +0700, Vladimir Voroshilov wrote:
> [...]
>> If you need any other tests, help me to make them.
>
> iam interrested in a single test, and i thought that was clear
> but apparently it was not
>
> The question is which way of handling errors is best
> we need to know if my suggestion is better or not
> i really wonder what you tested or why
>
> its simple
> 1. your code
> 2. my code
>
> which sounds better / has better PSNR for various kinds of realistic errors
>
> Please keep in mind your patch is adding error concealment code, and i must
> admit its very light on justification of why its done as is instead of
> differently.
>
> Also i think it might be better to reject the g729 patchset, the amount of
> problems we again have in communiating seem to make a approval practically
> impossible.

If you thinks so, let it be.

> Code that looks non optimal needs strong justification not long threads
> saying little new.
>

Hopefully someone else will ave enought skills/knowledge to strongly
justify them, if
i'm unable.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719