[FFmpeg-devel] [PATCH] Yamaha SMAF decoder supports MA-2/MA-3/MA-5/MA-7

[Vitor Sessak]

???? wrote:
> Hi,
> 2009/6/28 Vitor Sessak <vitor1001 at gmail.com>:
> 
>>> +        /* Make sure it's followed by an Awa chunk, aka wave data */
>>> +        if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
>>> +            av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
>>> +            return -1;
>>> +        }
>>>     }
>>>  -    /* Make sure it's followed by an Awa chunk, aka wave data */
>>> -    if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
>>> -        av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
>>> -        return -1;
>>> -    }
>> This block has just been reindented. Please do not mix functional and
>> indentation/cosmetics changes in patches (even if it will result in a
>> temporarily broken indentation) or else they are much harder to review.
> 
> The above block is not cosmetic. Patch applied source is following:

I was referring only to the 5+ and 5- I quoted. Which one of the 
following 5 lines was actually changed beyond indentation? If none, it 
is a cosmetical change.

> +        /* Make sure it's followed by an Awa chunk, aka wave data */
> +        if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
> +            av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
> +            return -1;
> +        }
>      }
>  
> -    /* Make sure it's followed by an Awa chunk, aka wave data */
> -    if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
> -        av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
> -        return -1;
> -    }

-Vitor