[FFmpeg-devel] [PATCH] Yamaha SMAF decoder supports MA-2/MA-3/MA-5/MA-7

[Vitor Sessak]

Hi,

???? wrote:
> Hi, developers,
> 
> For the current ffmpeg, Yamaha SMAF MA-2/MA-3/MA-5/MA-7 can not decode.
> I send the patch that ffmpeg supports Yamaha SMAF MA-2/MA-3/MA-5/MA-7 format.

Just a comment:

> +        /* Make sure it's followed by an Awa chunk, aka wave data */
> +        if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
> +            av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
> +            return -1;
> +        }
>      }
>  
> -    /* Make sure it's followed by an Awa chunk, aka wave data */
> -    if ((tag & 0xffffff) != MKTAG('A', 'w', 'a', 0)) {
> -        av_log(s, AV_LOG_ERROR, "Unexpected SMAF chunk %08x\n", tag);
> -        return -1;
> -    }

This block has just been reindented. Please do not mix functional and 
indentation/cosmetics changes in patches (even if it will result in a 
temporarily broken indentation) or else they are much harder to review.

-Vitor