[FFmpeg-devel] [PATCH] png parser

[Kostya]

On Thu, Jun 25, 2009 at 07:35:30PM +0200, Michael Niedermayer wrote:
> On Thu, Jun 25, 2009 at 02:14:14PM +0200, Peter Holik wrote:
> > Michael Niedermayer schrieb:
> > > On Thu, Jun 25, 2009 at 12:59:07PM +0200, Peter Holik wrote:
> > >> Michael Niedermayer schrieb:
> > >> > On Wed, Jun 24, 2009 at 05:54:17PM +0200, Peter Holik wrote:
> > >> >> Michael Niedermayer schrieb:
[...]
> > >>
> > >> Anyway fighting against windmills is meaningless.
> > >>
> > >> Here now a version without dropping anything and using 32 Bits for
> > >> signature check instead of 64 Bits.
> > >
> > > why 32bit?
> > > isnt 64bit simpler for 64bit sigs?
> > 
> > suggested by "Kostya" <kostya.shishkov at gmail.com>
> > 
> > I also would prefere 64bits
> > 
> > What shall i do now?
> 
> i cant see a reason or advantage to use 32bit so use 64bit
> unless someome, kostya? can explain what advantage 32bit would
> have
> (and no it shouldnt matter speewise as normally these loops run only
> an insignificant number of iterations)

That was just a proposal since IIRC there were some objections against
using 64-bit state variable.

I'm sorry if this has caused any inconvenience.
 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB