[FFmpeg-devel] [PATCH] G.729 LSF decoding

[Vladimir Voroshilov]

2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Jun 25, 2009 at 06:33:18PM +0700, Vladimir Voroshilov wrote:
>> 2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
>> > On Thu, Jun 25, 2009 at 05:36:14PM +0700, Vladimir Voroshilov wrote:
>> >> 2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
>> >> > On Thu, Jun 25, 2009 at 09:45:59AM +0700, Vladimir Voroshilov wrote:
>> >> >> 2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
>> >> > [...]
>> >> >> @@ -263,6 +282,12 @@ static const int16_t cb_ma_predictor[2][MA_NP][10] = { /* (0.15) */
>> >> >> ? ?}
>> >> >> ?};
>> >> >>
>> >> >> +/**
>> >> >> + * ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? 15 ? ? ? ? 3
>> >> >> + * cb_ma_predictor_sum[j][i] = floor( 2 * (1.0 - sum ( cb_ma_predictor_float[j][k][i] ) ) )
>> >> >> + * ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?k=0
>> >> >
>> >> > vertical positions ...
>> >>
>> >> fixed.
>> >>
>> >> >
>> >> >
>> >> > [...]
>> >> >> @@ -169,6 +169,13 @@ static void lsf_decode(int16_t* lsfq, int16_t* past_quantizer_outputs[MA_NP + 1]
>> >> >> ? ? ?ff_acelp_reorder_lsf(lsfq, LSFQ_DIFF_MIN, LSFQ_MIN, LSFQ_MAX, 10);
>> >> >> ?}
>> >> >>
>> >> >> +/**
>> >> >> + * Restores LSP parameters using data from previous frame
>> >> > [...]
>> >> >> ?static void lsf_restore_from_previous(int16_t* lsfq,
>> >> >
>> >> > lsf or lsp ?
>> >>
>> >> :(
>> >> Neither first not second (according to spec).
>> >> This routine restores past LSP quantizer output using LSF from previous frame.
>> >
>> > the function name is crap as well ...
>>
>> function name does not belongs to this patch and are under discussion
>> in separate thread, isn't it?
>> This patch is not intended to rename function but just add comment to it.
>> This patch is irrelevant to function name, imho.
>>
>> Am i right that you don't want to accept this patch (even if patch
>> itself is ok) since it is related to
>> questionable ?lsf_restore_from_previous routine ?
>> Just say "delay it" and i'll put it to the end of my long patch list
>> and will not waste your time for fixing one word in each review.
>>
>> There are a lot of questionable things waiting in queue.
>
> iam in favor of delaying this patch until after the function name has
> been fixed

Ok.

>
> [...]
> --
> Michael ? ? GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Old school: Use the lowest level language in which you can solve the problem
> ? ? ? ? ? ?conveniently.
> New school: Use the highest level language in which the latest supercomputer
> ? ? ? ? ? ?can solve the problem without the user falling asleep waiting.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iD8DBQFKQ2FhYR7HhwQLD6sRAkb2AJ9J9blT91Nfzx1SLgQ6ag19UURSuQCfUqZO
> 2Iyw3XabOPKJzsZIGM6ZsDg=
> =m8Of
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>



-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719