[FFmpeg-devel] [PATCH] G.729 LSF decoding

[Michael Niedermayer]

On Thu, Jun 25, 2009 at 05:36:14PM +0700, Vladimir Voroshilov wrote:
> 2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
> > On Thu, Jun 25, 2009 at 09:45:59AM +0700, Vladimir Voroshilov wrote:
> >> 2009/6/25 Michael Niedermayer <michaelni at gmx.at>:
> > [...]
> >> @@ -263,6 +282,12 @@ static const int16_t cb_ma_predictor[2][MA_NP][10] = { /* (0.15) */
> >> ? ?}
> >> ?};
> >>
> >> +/**
> >> + * ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? 15 ? ? ? ? 3
> >> + * cb_ma_predictor_sum[j][i] = floor( 2 * (1.0 - sum ( cb_ma_predictor_float[j][k][i] ) ) )
> >> + * ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?k=0
> >
> > vertical positions ...
> 
> fixed.
> 
> >
> >
> > [...]
> >> @@ -169,6 +169,13 @@ static void lsf_decode(int16_t* lsfq, int16_t* past_quantizer_outputs[MA_NP + 1]
> >> ? ? ?ff_acelp_reorder_lsf(lsfq, LSFQ_DIFF_MIN, LSFQ_MIN, LSFQ_MAX, 10);
> >> ?}
> >>
> >> +/**
> >> + * Restores LSP parameters using data from previous frame
> > [...]
> >> ?static void lsf_restore_from_previous(int16_t* lsfq,
> >
> > lsf or lsp ?
> 
> :(
> Neither first not second (according to spec).
> This routine restores past LSP quantizer output using LSF from previous frame.

the function name is crap as well ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090625/0a832a42/attachment.pgp>