[FFmpeg-devel] [PATCH] libswscale: Altivec, C and runtime cpu detection

[Adrian Stutz]

On Thu, Jun 25, 2009 at 12:20 PM, Diego Biurrun<diego at biurrun.de> wrote:
> I can reproduce now twith --enable-gpl, which is a separate bug in
> itself.
>
>> Note that without --enable-gpl the runtime CPU detection in libswscale
>> won't be used (shouldn't there be a warning about this?).
>
> You mean a warning from configure or what?

Well, if it's a bug then it should be fixed. But if it's intentional
however and the runtime cpu detection code in libswscale requires some
GPL code then configure should IMHO behave the same way as with e.g.
libpostproc (fail without GPL).

Since there are other parts in ffmpeg that can use runtime cpu
detection without GPL, it would require a separate configure option
for libswscale runtime cpu detection or at least show a warning to the
user that libswscale won't use runtime cpu detection because GPL is
not enabled, which I think would be more appropriate.

> Anyway, I committed what I consider a slightly better fix..

Thanks!

Greetings
Adrian