[FFmpeg-devel] qt-faststart update

[Diego Biurrun]

On Wed, Jun 24, 2009 at 05:14:39AM -0700, Frank Barchard wrote:
> 
> --------------------------------------------------
> From: "Diego Biurrun" <diego at biurrun.de>
> Sent: Wednesday, June 24, 2009 2:54 AM
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at mplayerhq.hu>
> Subject: Re: [FFmpeg-devel] qt-faststart update

You will extra good karma if you remove these ugly headers..

> >On Wed, Jun 24, 2009 at 01:52:36AM -0700, Frank Barchard wrote:
> >>
> >>> On Tue, Jun 23, 2009 at 07:39:55PM -0700, Frank Barchard wrote:
> >>--- tools/qt-faststart.orig.c 2009-05-07 21:41:30.000000000 -0700
> >>+++ tools/qt-faststart.c 2009-06-24 01:04:39.804309200 -0700
> >>@@ -26,7 +27,15 @@
> >>
> >> #include <stdio.h>
> >> #include <stdlib.h>
> >>+#ifndef _MSC_VER
> >> #include <inttypes.h>
> >>+#else
> >>+#define uint64_t unsigned __int64
> >>+#define uint32_t unsigned int
> >>+#define uint8_t unsigned char
> >>+#define ftello _ftelli64
> >>+#define fseeko _fseeki64
> >>+#endif
> >
> >We do not support Visual Studio, get rid of this.  In any case, it would
> >have to be a separate patch.
> 
> I'm needing VC for debugging.  It also produces faster code if built with 
> Intel C or VC for Windows.

This is irrelevant, VC workarounds have no place in this patch.  Send one
issue per patch.

> Keep in mind this is a stand alone tool, not linked into ffmpeg libraries.
> I'll submit a separate patch to the original for VC support.

Don't bother, VC workarounds are rejected.

> >Also, please set a correct content-type for your attachments.
> 
> I'm not sure how to do that?  The previous attachments were thru gmail.
> For this one I've switched to Live Mail in plain text format.

It's equally bad, plus Live Mail mimics Outlook formattting, which looks
horrible.  Some people do manage to set correct mime-type even when
using webmail...


The patch looks much better.  Can we now have the factorization as a
separate patch please?

Diego