[FFmpeg-devel] [PATCH] make stream-switching work with MOV demuxer

[Baptiste Coudurier]

Reimar D?ffinger wrote:
> On Wed, Jun 24, 2009 at 12:50:20AM -0700, Baptiste Coudurier wrote:
>> Reimar D?ffinger wrote:
>>> On Tue, Jun 23, 2009 at 01:06:58PM -0700, Baptiste Coudurier wrote:
>>>> The other patch looks ok, and it is not uglier IMHO, it will allow sc =
>>>> msc removal since sc == st->priv_data, and sc->ffindex will no longer be
>>>> needed.
>>> Ok, let's get that part out of the way, see attached patch.
>>> Personally I'd even suggest making a
>>> AVIndexEntry *find_next_sample(AVFormatContext *s, AVStream **st);
>>> or similar that contains the whole for loop, making mov_read_packet
>>> a bit more self-documenting.
>> Yes good idea and patch ok.
> 
> Not sure if the idea is that good, but here is a patch for that extra
> function, too.
> Names, as always, are of course open for improvements.

I like having functions names starting with mov_ or mp4_ in this file.
Except that if you want to apply it, I'm ok.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org