[FFmpeg-devel] [PATCH] run level decode function for wma &?wmapro

[Sascha Sommer]

Hi,

On Freitag, 12. Juni 2009, Michael Niedermayer wrote:
> On Fri, Jun 12, 2009 at 10:18:49AM +0200, Sascha Sommer wrote:
> > Hi,
> >
> > On Donnerstag, 11. Juni 2009, Michael Niedermayer wrote:
> > > On Thu, Jun 11, 2009 at 10:17:19PM +0200, Sascha Sommer wrote:
> > > > Hi,
> > > >
> > > > attached patch adds a run level decode function that can be used for
> > > > both wma12 and wmapro.
> > >
> > > could you split it into a patch factorizig the code out and one
> > > changing it ?
> > > so that code moving around is seperate from functional changes ...
> > >
> > > [...]
> >
> > Attached patch adds the escape decode code for wmapro.
>
> ok
>

Commited.

Regards

Sascha



>From Diego E.  Sat Jun 20 12:57:31 2009
From: Diego E. (Diego E.)
Date: Sat, 20 Jun 2009 12:57:31 +0200
Subject: [FFmpeg-devel] exported symbols in libswscale
In-Reply-To: <87vdmrb6fk.fsf at faui44a.informatik.uni-erlangen.de>
References: <87vdmrb6fk.fsf at faui44a.informatik.uni-erlangen.de>
Message-ID: <1245495451.7254.4.camel at yamato>

Il giorno Sat, 20/06/2009 alle 11.28 +0200, Reinhard Tartler ha scritto:
> 
> If yes, I guess these symbols should ideally not be exported in
> libswscale.so.0 at all in the first place then, correct?
> 
I'm not exactly the best person to say that, but I'd guess so.

I (and I wasn't the only one) tried to set up hidden visibility on the
symbols before (so that it would reduce the load time), but, with my try
at least, the amount patching that was needed to allow the external
symbols to be exported, as well as the fact that some internal symbols
were needed between the libraries (I think this was mostly fixed
afterward), made the issue not easy to solve.

For all the internal symbols prefixed by ff_ one could actually just use
a linker script to stop them from being exported (on the other hand,
hidden visibility should give a better clue to the compilers supporting
inter-object optimisation, but I sincerely doubt GCC does).

-- 
Diego Elio Petten? ? ?Flameeyes?
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Questa ? una parte del messaggio firmata digitalmente
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090620/eafbccf9/attachment.pgp>