[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

[Michael Niedermayer]

On Thu, Jun 18, 2009 at 09:46:31AM -0400, Ronald S. Bultje wrote:
> Hi Michael,
> 
> On Thu, Jun 18, 2009 at 9:03 AM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > On Sun, Jun 14, 2009 at 10:09:14PM -0400, Ronald S. Bultje wrote:
> > > +#include <libavcodec/internal.h>
> >
> > what is this good for?
> 
> 
> libavformat/rtp_asf.c:214: warning: implicit declaration of function
> ?ff_log_missing_feature?

either ff_log_missing_feature is internal to lavc then you cant use it in
lavf or its external 

[...]

> Index: ffmpeg-svn/libavformat/asfdec.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/asfdec.c	2009-06-18 09:38:16.000000000 -0400
> +++ ffmpeg-svn/libavformat/asfdec.c	2009-06-18 09:41:43.000000000 -0400
> @@ -606,6 +606,15 @@
>      }
>  
>      if (c != 0x82) {
> +        /**
> +         * This code allows handling of -EAGAIN at packet boundaries (i.e.
> +         * if the packet sync code above triggers -EAGAIN. This by no means
> +         * implies complete -EAGAIN handling support, such as what would
> +         * happen when streaming an ASF file over HTTP via a non-blocking
> +         * socket, but it is sufficient to handle e.g. ASF over RTP.
> +         */
> +        if (url_ferror(pb) == -EAGAIN)
> +            return -EAGAIN;
>          if (!url_feof(pb))
>              av_log(s, AV_LOG_ERROR, "ff asf bad header %x  at:%"PRId64"\n", c, url_ftell(pb));
>      }

bleh, this is confusing
asf, the demuxer has no business with http and rtp, any explanation of the
code should be free of references to them

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090618/9de8e3ce/attachment.pgp>