[FFmpeg-devel] [PATCH] G.729 parameters decoding

[Vladimir Voroshilov]

2009/6/18 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Jun 18, 2009 at 06:55:09AM +0700, Vladimir Voroshilov wrote:
>> 2009/6/18 Michael Niedermayer <michaelni at gmx.at>:
>> > On Sat, Jun 13, 2009 at 01:21:24AM +0700, Vladimir Voroshilov wrote:
>> >
>> > [...]
>> >> + ? ?for (i = 0; i < 2; i++) {
>> >> + ? ? ? ?uint8_t ac_index; ? ? ?///< adaptive codebook index
>> >> + ? ? ? ?uint8_t pulses_signs; ?///< fixed-codebook vector pulse signs
>> >> + ? ? ? ?int fc_indexes; ? ? ? ?///< fixed-codebook indexes
>> >> + ? ? ? ?uint8_t gc_1st_index; ?///< gain codebook (first stage) index
>> >> + ? ? ? ?uint8_t gc_2nd_index; ?///< gain codebook (second stage) index
>> >> +
>> >> + ? ? ? ?ac_index ? ? ?= get_bits(&gb, format.ac_index_bits[i]);
>> >
>> >> + ? ? ? ?if(!i && format.parity_bits) {
>> >> + ? ? ? ? ? ?int parity = get_bits(&gb, format.parity_bits);
>> >> + ? ? ? ? ? ?bad_pitch = get_parity(ac_index) == parity;
>> >> + ? ? ? ?}
>> >
>> > uhm ugh
>> >
>> > bad_pitch = get_parity(show_bits(format.ac_index_bits[0] + format.parity_bits);
>> > prior to the loop
>>
>> If format.parity_bits==0 this code will become to:
>> ?bad_pitch = get_parity(show_bits(format.ac_index_bits[0]);
>
> if(format.parity_bits)
> ? ?...
>
> and its actually parity_bit not bits


...and i still have to check parity_bits inside for() too,
since get_bits(pgb, 0) does not work. don't know why.
Where is benefit ?

>
> [...]
> --
> Michael ? ? GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Breaking DRM is a little like attempting to break through a door even
> though the window is wide open and the only thing in the house is a bunch
> of things you dont want and which you would get tomorrow for free anyway
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iD8DBQFKOYMyYR7HhwQLD6sRAuCWAJ0Qs/YJov5nRUeqCJP5G0omm3nhIACdEJk+
> 79AnjbDbsaFzPdNqrZd+a34=
> =wecn
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>



-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719