[FFmpeg-devel] [PATCH] G.729 parameters decoding

[Michael Niedermayer]

On Thu, Jun 18, 2009 at 06:55:09AM +0700, Vladimir Voroshilov wrote:
> 2009/6/18 Michael Niedermayer <michaelni at gmx.at>:
> > On Sat, Jun 13, 2009 at 01:21:24AM +0700, Vladimir Voroshilov wrote:
> >
> > [...]
> >> + ? ?for (i = 0; i < 2; i++) {
> >> + ? ? ? ?uint8_t ac_index; ? ? ?///< adaptive codebook index
> >> + ? ? ? ?uint8_t pulses_signs; ?///< fixed-codebook vector pulse signs
> >> + ? ? ? ?int fc_indexes; ? ? ? ?///< fixed-codebook indexes
> >> + ? ? ? ?uint8_t gc_1st_index; ?///< gain codebook (first stage) index
> >> + ? ? ? ?uint8_t gc_2nd_index; ?///< gain codebook (second stage) index
> >> +
> >> + ? ? ? ?ac_index ? ? ?= get_bits(&gb, format.ac_index_bits[i]);
> >
> >> + ? ? ? ?if(!i && format.parity_bits) {
> >> + ? ? ? ? ? ?int parity = get_bits(&gb, format.parity_bits);
> >> + ? ? ? ? ? ?bad_pitch = get_parity(ac_index) == parity;
> >> + ? ? ? ?}
> >
> > uhm ugh
> >
> > bad_pitch = get_parity(show_bits(format.ac_index_bits[0] + format.parity_bits);
> > prior to the loop
> 
> If format.parity_bits==0 this code will become to:
>  bad_pitch = get_parity(show_bits(format.ac_index_bits[0]);

if(format.parity_bits)
    ...

and its actually parity_bit not bits

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090618/29a10dc5/attachment.pgp>