[FFmpeg-devel] [PATCH] h264 ticks and time base

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Sun, Jun 14, 2009 at 10:42:11PM -0700, Baptiste Coudurier wrote:
>> Hi,
>>
>> 1) Set avctx time_base in h264 parser.
>> 2) Set avctx ticks_per_frame in h264 decoder.
>>
>> I don't get this code in decode_init in h264.c
>>
>>     reset_sei(h);
>>     if(avctx->codec_id == CODEC_ID_H264){
>>         if(avctx->ticks_per_frame == 1){
>>             s->avctx->time_base.den *=2;
>>         }
>>         avctx->ticks_per_frame = 2;
>>     }
>>     return 0;
>>
>> avctx->ticks_per_frame is not set before calling the decoder
>> in any case. Should that be removed ?
> 
> what do you mean by "that" ?

the if(avctx->ticks_per_frame == 1)

>> [...]
>>
>> @@ -3840,6 +3840,7 @@
>>                  s->avctx->time_base.den *= 2;
>>              av_reduce(&s->avctx->time_base.num, &s->avctx->time_base.den,
>>                        s->avctx->time_base.num, s->avctx->time_base.den, 1<<30);
>> +            s->avctx->ticks_per_frame = 2;
>>          }
>>      }
> 
> ticks_per_frame has already been set during init
> 

Right.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org