[FFmpeg-devel] [PATCH] new av_audio_resample

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Thu, Jun 11, 2009 at 03:14:21PM -0700, Baptiste Coudurier wrote:
>> On 6/11/2009 2:58 PM, Michael Niedermayer wrote:
>>> On Thu, Jun 11, 2009 at 01:41:59AM -0700, Baptiste Coudurier wrote:
>>>> Hi guys,
>>>>
>>>> I propose to introduce av_audio_resample to add output_size as parameter
>>>> since currently using audio_resample there is no way to know the size of
>>>> the output buffer.
>>> I hoped we could one day drop resample.c in favor of resample2.c
>>> currently resample.c lacking a av prefix is not officially part of the public
>>> API your patch would change that
>>>
>>> and i belive the API of resample.c is not fit for export, the output_size
>>> is surely needed but thats not the only thing, using short types is clearly
>>> not correct given the code supports other types, lack of planar audio support
>>> in the API also is not good.
>> Yes you are right.
>>
>> Nobody is inclined to clean it up and reimplement.
>> Now we have buggy code causing crashes.
> 
> you are right as well
> 
> what about adding a 2 at the end instead of a av_ at the begin of the new
> function name? that would make me a lot happier with the patch

Well, no problem for me, but we added av_audio_resample before :/
if this is meant to be private maybe we should remove it from avcodec.h
and keeping it private, no ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org