[FFmpeg-devel] [PATCH] Additional probing based on sequence header and group startcodes

[Michael Niedermayer]

On Sat, Jun 13, 2009 at 02:29:44PM -0700, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > On Sat, Jun 13, 2009 at 08:27:26PM +0000, Jai Menon wrote:
> >> Hi,
> >>
> >> I'm not too familiar with the probing mechanism so any help is
> >> appreciated. This might not be the right way to do it. Also, this
> >> fixes issue 1185 and possibly others.
> > [...]
> >> diff --git a/libavformat/utils.c b/libavformat/utils.c
> >> index dc18885..0096343 100644
> >> --- a/libavformat/utils.c
> >> +++ b/libavformat/utils.c
> >> @@ -339,6 +339,9 @@ static int set_codec_from_probe_data(AVStream *st, AVProbeData *pd, int score)
> >>          } else if (!strcmp(fmt->name, "dts")) {
> >>              st->codec->codec_id = CODEC_ID_DTS;
> >>              st->codec->codec_type = CODEC_TYPE_AUDIO;
> >> +        } else if (!strcmp(fmt->name, "mpeg")) {
> >> +            st->codec->codec_id = CODEC_ID_MPEG2VIDEO;
> >> +            st->codec->codec_type = CODEC_TYPE_VIDEO;
> >>          }
> >>      }
> >>      return !!fmt;
> > 
> > this part is ok and can be commited seperately
> 
> Humm, what if stream contain H264 ? "mpeg" is mpeg ps demuxer.

argh, right, i thought it was mpegvideo, so that hunk is not ok
sorry for the sloppy review

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090613/1539ca77/attachment.pgp>