[FFmpeg-devel] [PATCH] Default to using libraries when enabled

[Baptiste Coudurier]

On 6/11/2009 2:43 AM, Ivan Kalvachev wrote:
> On 6/11/09, David Conrad <lessen42 at gmail.com> wrote:
>> On May 31, 2009, at 9:20 PM, David Conrad wrote:
>>
>>> On May 28, 2009, at 6:50 AM, M?ns Rullg?rd wrote:
>>>
>>>> Diego Biurrun <diego at biurrun.de> writes:
>>>>
>>>>> On Thu, May 28, 2009 at 11:33:44AM +0100, M?ns Rullg?rd wrote:
>>>>>> Diego Biurrun <diego at biurrun.de> writes:
>>>>>>
>>>>>>> On Wed, May 20, 2009 at 08:20:36PM -0400, David Conrad wrote:
>>>>>>>> This changes the order of initialization so that external
>>>>>>>> libraries
>>>>>>>> that are enabled are used by default over native codecs.
>>>>>>> I did this on purpose, native implementations should be preferred.
>>>>>> Even when the native implementations are worse than using /dev/
>>>>>> random?
>>>>> Then that native implementation should be removed or treated
>>>>> separately.
>>>> So, who's in favour of removing/disabling the native vorbis bitstream
>>>> writer?
>>> Well I haven't heard anyone object, so I'll disable it in a week if
>>> noone pipes up. The code will still be in svn for anyone that wants
>>> to revive it.
>> I went ahead and disabled the encoder with Diego's suggestions; it's a
>> one line change if anyone wants to revive it in the future, but for
>> now noone should be confused as to why they get so low quality with
>> Vorbis.
> 
> Sorry for coming late.
> 
> I don't like that trend. The vorbis encoder is not the only encoder
> that produces
> worse quality than alternative tools. This applies to mp2, ac3, and probably
> any other audio and video encoder.
> 
> I thought it is ffmpeg policy to don't babysit users.

Well the only thing missing is psychoacoustic model.
Besides it produces good quality at high bitrate. There is still a peak
problem with mp2 notified in roundup, but it does not seem to appear
when floats are used in encoding.

I don't think you can compare vorbis encoder state to mp2 and ac3.
What's another good ac3 encoder open source ?

Still I'm not necessarily happy to drop vorbis encoder but its state
does not seem to attract any developper, so there is not much we can do
about it. Could AAC encoder work benefit Vorbis ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org