[FFmpeg-devel] [PATCH] G.729 initialization routine (skeleton)

[Michael Niedermayer]

On Wed, Jun 10, 2009 at 12:27:35AM +0700, Vladimir Voroshilov wrote:
> 2009/6/10 Michael Niedermayer <michaelni at gmx.at>:
> > On Tue, Jun 09, 2009 at 11:30:17PM +0700, Vladimir Voroshilov wrote:
> >> 2009/6/9 Michael Niedermayer <michaelni at gmx.at>:
> >> > On Sun, Jun 07, 2009 at 12:28:37AM +0700, Vladimir Voroshilov wrote:
> >> >> 2009/6/7 Diego Biurrun <diego at biurrun.de>:
> >> >> > On Sun, Jun 07, 2009 at 12:18:10AM +0700, Vladimir Voroshilov wrote:
> >> >> >>
> >> >> >> Here is patch without format.
> >> >> >>
> >> >> >> --- ffmpeg-r19125.orig/libavcodec/g729dec.c
> >> >> >> +++ ffmpeg-r19125.mod/libavcodec/g729dec.c
> >> >> >> @@ -97,11 +101,39 @@ static inline int get_parity(uint8_t value)
> >> >> >>
> >> >> >> +static int decoder_init(AVCodecContext * avctx)
> >> >> >
> >> >> > This function should likely be marked av_cold.
> >> >> >
> >> >> > Please doublecheck which other functions could receive this attribute.
> >> >> >
> >> >>
> >> >> decoder_init does not call other internal routines, thus no additional
> >> >> routines require this attribute, imho.
> >> >> fixed.
> >> > [...]
> >> >
> >> >> + ? ?if (avctx->sample_rate == 8000) {
> >> >> + ? ? ? ?ctx->subframe_size = 40;
> >> >> +#ifdef G729_SUPPORT_4400
> >> >> + ? ?} else if (avctx->sample_rate == 4400) {
> >> >> + ? ? ? ?ctx->subframe_size = 44;
> >> >> +#endif
> >> >> + ? ?} else {
> >> >> + ? ? ? ?av_log(avctx, AV_LOG_ERROR, "Sample rate %d is not supported.\n", avctx->sample_rate);
> >> >> + ? ? ? ?return AVERROR_NOFMT;
> >> >> + ? ?}
> >> >
> >> > ? ?ctx->subframe_size = 40;
> >> > #ifdef G729_SUPPORT_4400
> >> > ? ?if (avctx->sample_rate == 4400) {
> >> > ? ? ? ?ctx->subframe_size = 44;
> >> > ? ?}
> >> > #endif
> >>
> >> In this casse you'll get garbage sound instead of meanfull error
> >> message for unsupported g.729 modes.
> >
> > which mode?
> 
> G.729 standard also describes 11.5k and 6.4k modes (and also several
> non-standard modes exists, like above 4.4k).
> So what will be happend if such mode will be passed to decoder ?

as the values you quote are bitrates and the check is testing the
samplerate ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090609/ac629e79/attachment.pgp>