[FFmpeg-devel] [PATCH] swscale.c

[Reimar Döffinger]

On Thu, Jun 04, 2009 at 12:29:56PM -0400, Pavel Pavlov wrote:
> > -----Original Message-----
> > > I simply prefer to use one macro everywhere, instead of ten others. 
> > > DECLARE_ASM_CONST just makes it less clear; with 
> > DECLARE_ALIGNED it's 
> > > obvious that alignment is required and that variable is 
> > static or not.
> > 
> > If you don't use DECLARE_ASM_CONST for "static const" stuff 
> > that is used via MANGLE in asm code you will break ICC compilation.
> 
> 
> In this regard my path is correct. It doesn't modify anything except it 
> specifies alignment via DECLARE_ALIGNED macro instead of gcc specific
> way.
> Static/non-static modifiers are not touched at all.

Well... That it doesn't change anything in that regard doesn't mean that
it can't be wrong before and after.
Also I only meant to explain the specific purpose of DECLARE_ASM_CONST,
which maybe isn't be best-chose name.

> Check all the diffs I sent. They are small and you can inspect all of
> them 
> in 5 minutes.

Yes, they seem ok in that regard, those files don't really use MANGLE
much.