[FFmpeg-devel] [PATCH] Add DPX decoder rev-20

[Jimmy Christensen]

On 2009-06-04 15:00, Diego Biurrun wrote:
> On Thu, Jun 04, 2009 at 02:55:08PM +0200, Jimmy Christensen wrote:
>> On 2009-06-04 13:31, Michael Niedermayer wrote:
>>>
>>>> +    bpc = AV_RB16(buf);
>>>
>>> what is bpc? i think this is not a good name for a variable
>>
>> Bits per color. Renamed it to bitsPerColor.
>
> Could we please have this without the ugly camelcasing, e.g.
> bits_per_color?
>

Renamed. Guess I get that habit from my main line of work :)

>> --- libavcodec/dpx.c	(revision 0)
>> +++ libavcodec/dpx.c	(revision 0)
>> @@ -0,0 +1,187 @@
>> +    const uint8_t *buf          = avpkt->data;
>> +    int buf_size                = avpkt->size;
>
> nit: This looks slightly odd moved so much to the right.
>

Think it was due to some names I had earlier which were removed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpegDPX-rev20.diff
Type: text/x-patch
Size: 8961 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090604/f8844828/attachment.bin>