[FFmpeg-devel] [PATCH] swscale.c

[Reimar Döffinger]

On Wed, Jun 03, 2009 at 08:19:14PM -0400, Pavel Pavlov wrote:
> > -----Original Message-----
> > On Wed, Jun 3, 2009 at 2:56 PM, Pavel Pavlov 
> > <pavel at summit-tech.ca> wrote:
> > > Old:
> > > ? ? ? ?static const uint8_t ?__attribute__((aligned(8))) 
> > > dither_2x2_4[2][8]={
> > >
> > > New:
> > > ? ? ? ?DECLARE_ALIGNED(8, static const uint8_t, 
> > dither_2x2_4[2][8])={
> > 
> > Hmm, shouldn't some of these (also in your other patches) use 
> > DECLARE_ASM_CONST?
> > 
> > Also is it best to:
> > DECLARE_ALIGNED(8, static const
> > static const DECLARE_ALIGNED(8
> > or some other combination?
> > 
> > Some grepping shows we have a couple of different 
> > combinations for those.
> 
> I simply prefer to use one macro everywhere, instead of ten others. 
> DECLARE_ASM_CONST just makes it less clear; with DECLARE_ALIGNED
> it's obvious that alignment is required and that variable is static or
> not.

If you don't use DECLARE_ASM_CONST for "static const" stuff that is used
via MANGLE in asm code you will break ICC compilation.