[FFmpeg-devel] [PATCH] Move url_readbuf() to common functions

[Michael Niedermayer]

On Wed, Jun 03, 2009 at 06:55:41PM +0300, Kostya wrote:
> On Wed, Jun 03, 2009 at 05:44:13PM +0200, Michael Niedermayer wrote:
> > On Tue, Jun 02, 2009 at 06:44:55PM +0300, Kostya wrote:
> > > Reason: read on network connections may retrieve less bytes than needed
> > > and we need to call reading function several times until required amount
> > > of data is read. libavformat/rtsp.c contains such function which I
> > > propose to move to common place (I use in my RTMP demuxer).
> > 
> > a demuxer or protocol should return with EAGAIN instead of blocking
> > if AVFMT_FLAG_NONBLOCK is set.
> > 
> > that said there is nothing network specific in this and thus network
> > does not belong in the function name
> > a reasonable name could be url_read_complete()
> 
> Any other comments beside appropriate name?

no, you are just moving & renaming a function ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090603/e946a1d4/attachment.pgp>