[FFmpeg-devel] PATCH: av_strtod

[Reimar Döffinger]

On Mon, Jun 01, 2009 at 09:38:00PM -0400, Pavel Pavlov wrote:
>  
> 
> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Reimar D?ffinger
> Sent: June 01, 2009 04:08
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] PATCH: av_strtod
> 
> On Mon, Jun 01, 2009 at 01:27:52AM -0400, Pavel Pavlov wrote:
> > Biggest problem is the black voodoo code related to inline assembly 
> > and
> > MANGLE(...) plus the worst ever code is in recently added 
> > mlp_filter_channel_x86, which mangles lables. WTF, why not a 
> > standalone .asm file instead?!?
> 
> And how would you do that with a plain .asm file? Write the function setup code yourself (meaning you will only support the select few architectures you explicitly write code for) or using yasm (meaning you will support only the less select but still quite few architectures ABIs it supports)?
>
> 
> Well, for that file instead of storing pointers to labels and doing repeatative jumps in the loop I wrote mlpdsp_template.c that creates using C preprocessor 8*4 functions mlp_filter_channel_x86_X_Y and I use table of function pointers and call a function based on the X and Y. That was just about the only way I could make that function work on for intel compiler.

So even you did not use a plain .asm file.
I didn't say that you couldn't implement the same code without jumps
(though it is questionable it won't be slower), I was just saying that I
can't see how a solution using a standalone .asm would be comparable.