[FFmpeg-devel] svq3.c: parse frame size

[Ronald S. Bultje]

Hi,

On Thu, Jul 30, 2009 at 4:34 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Thu, Jul 30, 2009 at 10:12:47AM -0400, Ronald S. Bultje wrote:
>> On Thu, Jul 30, 2009 at 2:42 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
>> > On Wed, Jul 29, 2009 at 12:00:52PM -0400, Ronald S. Bultje wrote:
>> >> + ? ? ? ? ? ?if (avctx->width <= 0 || avctx->height <= 0) {
>> >
>> > why only then?
[..]
>> OK, so now for that case where svq3 and demuxer tell us something
>> different: which do you trust more? My answer was that I trust the
>> demuxer more. Why? Well, because this comes from the wiki and is
>> relatively untested. I mean, it works for my videos, but it's still
>> not as tested as the .mov size parsing code ( :-) ).
>
> i trust the decoder more, please change it to that, it might even fix
> some svq3 files, if not and it breaks something this is very easy to
> undo and do differently.

OK, see attached.

Ronald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svq3-read-size.patch
Type: text/x-diff
Size: 1510 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090730/dae7fa60/attachment.patch>