[FFmpeg-devel] RTP/SVQ3 payload parser

[Ronald S. Bultje]

Hi,

On Wed, Jul 29, 2009 at 12:10 PM, Diego Biurrun<diego at biurrun.de> wrote:
> On Wed, Jul 29, 2009 at 12:01:54PM -0400, Ronald S. Bultje wrote:
>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>> +++ ffmpeg-svn/libavformat/rtp_svq3.c 2009-07-29 11:50:53.000000000 -0400
>> @@ -0,0 +1,148 @@
>> +
>> +/**
>> + * @file libavformat/rtp-sv3v.c
>
> That ain't right.
[..]
>> +static PayloadContext *
>> +sv3v_extradata_new(void)
>> +
>> +static void
>> +sv3v_extradata_free(PayloadContext *sv)
>
> K&R please...

Oops. New version attached.

>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>> +++ ffmpeg-svn/libavformat/rtp_svq3.h 2009-07-29 11:54:06.000000000 -0400
>> @@ -0,0 +1,33 @@
>> +
>> +#include "libavcodec/avcodec.h"
>> +#include "rtpdec.h"
>
> What are these good for?  You could #include them directly in the C
> file.

rtpdec.h contains the RTPDynamicProtocolHandler def, so it's needed.
The other one is not, so removed.

> And why sv3v instead of svq3? ?Prefixes for static functions are
> unnecessary in any case.

The payload ID is 'SV3V', that's why. I can rename, I didn't think it
was important. The prefixes are used everywhere (no ff_), or else
we'll have 20 functions called extradata_new() in rtp_*.c.

Ronald