[FFmpeg-devel] [PATCH] Fix decoding of problematic rawvideo MOV file

[Jason Garrett-Glaser]

On Sat, Jul 25, 2009 at 1:24 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Thu, Jul 23, 2009 at 03:14:07PM -0700, Jason Garrett-Glaser wrote:
>> Attached patch fixes "WRAW" mov files with BGR24 raw video.
>
> what is WRAW?
> Win32 RGB RAW ?

It's Windows raw formats according to Quicktime docs--which it seems
could be anything.

>
> [...]
>> @@ -88,7 +88,8 @@
>> ? ? ? ? ?return -1;
>>
>> ? ? ?if((avctx->extradata_size >= 9 && !memcmp(avctx->extradata + avctx->extradata_size - 9, "BottomUp", 9)) ||
>> - ? ? ? avctx->codec_tag == MKTAG( 3 , ?0 , ?0 , ?0 ))
>> + ? ? ? ?avctx->codec_tag == MKTAG( 3 , ?0 , ?0 , ?0 ) ||
>> + ? ? ? (avctx->codec_tag == MKTAG('W', 'R', 'A', 'W') && avctx->bits_per_coded_sample == 24))
>> ? ? ? ? ?context->flip=1;
>>
>
> the bits_per_coded_sample check looks wrong

Why?  I know that the PAL8 sample wasn't flipped, and my BGR24 sample
is flipped, so that's the only thing I could come up with.

Dark Shikari