[FFmpeg-devel] [PATCH] First shot at AVCHD seeking via new seeking API

Ivan Schreter schreter
Sat Jul 25 13:14:12 CEST 2009


Hi,

Ivan Schreter wrote:
> Hi Baptiste,
> [...]
> I see we have a header "internal.h" in lavf. So I moved the 
> declaration of my new routine there. This is then definitely no public 
> API.
>
> OK to commit now (patches attached)?
>
Since noone reviewed my patches for about three weeks, I reviewed them 
myself and wrote an extended seek test, which tests whether seeked-to 
position really fulfills the contract of avformat_seek_file. This did 
reveal a small problem, which I fixed. BTW, other formats also have 
issues, so I'll probably send a patch for seek test to the list, when 
time permits.

I also simplified the code by removing handling of special cases, since 
it just made it less clear. Here is the newest set of patches.

Special case handling of seeking before first keyframe or after the last 
keyframe is now handled only for old seeking API inside of mpegts.c 
read_seek(). New seeking API will return -1 if trying to seek outside of 
timestamp range.

If noone objects, I'll commit them during the next week.

Regards,

Ivan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: seek_cooked_lavf.patch
Type: text/x-patch
Size: 17542 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090725/ecc57c6f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: seek_cooked_mpegts.patch
Type: text/x-patch
Size: 3827 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090725/ecc57c6f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: seek_cooked_seekregress.patch
Type: text/x-patch
Size: 4530 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090725/ecc57c6f/attachment-0002.bin>



More information about the ffmpeg-devel mailing list