[FFmpeg-devel] [PATCH] Arm assembly for WinCE (Was Re: [PATCH] WinCE does not support _lseeki64)

[Martin Storsjö]

On Tue, 21 Jul 2009, M?ns Rullg?rd wrote:

> Martin Storsj? <martin at martin.st> writes:
> 
> > diff --git a/libavcodec/arm/asm.S b/libavcodec/arm/asm.S
> > index 087b279..07a38d3 100644
> > --- a/libavcodec/arm/asm.S
> > +++ b/libavcodec/arm/asm.S
> > @@ -21,18 +21,24 @@
> >  #include "config.h"
> >  
> >          .macro require8, val=1
> > +#if HAVE_EABI_ATTRIBUTE
> >          .eabi_attribute 24, \val
> > +#endif
> >          .endm
> >  
> >          .macro preserve8, val=1
> > +#if HAVE_EABI_ATTRIBUTE
> >          .eabi_attribute 25, \val
> > +#endif
> >          .endm
> >  
> >          .macro function name, export=0
> >  .if \export
> >          .global \name
> >  .endif
> > +#if HAVE_ARM_ASM_TYPE
> >          .type   \name, %function
> > +#endif
> >          .func   \name
> >  \name:
> >          .endm
> 
> These could all just be under #ifdef __ELF__ instead.  Those
> directives are only supported for ELF targets, according to the
> manual.

Ah, yes, that's much nicer - didn't know about that preprocessor define. 
Updated patch attached.

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Use-.eabi_attribute-and-.type-only-for-ELF.patch
Type: text/x-diff
Size: 727 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090721/5d1768e2/attachment.patch>