[FFmpeg-devel] [PATCH] libavfilter-soc: regression test for libavfilter

Michael Niedermayer michaelni
Tue Jul 21 03:45:56 CEST 2009


On Sun, Jul 12, 2009 at 01:39:43PM +0200, Stefano Sabatini wrote:
> On date Sunday 2009-07-05 20:47:57 +0200, Stefano Sabatini encoded:
> > On date Sunday 2009-06-21 22:58:26 +0200, Stefano Sabatini encoded:
> > > Hi, as in subject.
> > > 
> > > Especially ideas for more meaningful tests are very welcome.
> 
> Patch updated with some factorization and the vflip test removed.
> 
> I also changed the subject as I consider the reg-test already useful
> when testing it, so I'm proposing it for committing in the soc repo.

Is there something preventing this to be commited to main? (with the test
disabled of course until the needed parts are in too)


[...]
> Index: libavfilter-soc/ffmpeg/tests/codec-regression.sh
> ===================================================================
> --- libavfilter-soc.orig/ffmpeg/tests/codec-regression.sh	2009-06-23 00:56:58.000000000 +0200
> +++ libavfilter-soc/ffmpeg/tests/codec-regression.sh	2009-07-12 13:34:42.000000000 +0200
> @@ -652,4 +652,20 @@
>  done
>  fi
>  
> +# libavfilter testing
> +
> +function do_lavfi() {
> +    test_name=$1
> +    eval test=\$do_$test_name
> +    vfilters=$2
> +
> +    if [ -n "$test" ] ; then
> +        do_video_encoding ${test_name}.avi "-qscale 10" "-vcodec huffyuv -vfilters $vfilters"
> +    fi
> +}
> +
> +do_lavfi "crop" "crop=100:100:-1:-1"
> +do_lavfi "crop_scale" "crop=100:100,scale=200:-1"
> +do_lavfi "scale" "scale=200:200"
> +

a todo list should be added somewhere about
direct rendering, slices, chains with feedback loops, ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090721/ee523bfe/attachment.pgp>



More information about the ffmpeg-devel mailing list