[FFmpeg-devel] [PATCH] First shot at AVCHD seeking via new seeking API

[Ivan Schreter]

Hi Baptiste,

Baptiste Coudurier wrote:
> Hi Ivan,
>
> On 07/16/2009 01:02 AM, Ivan Schreter wrote:
>> Hi Baptiste,
>>
>> Baptiste Coudurier wrote:
>>> On 07/07/2009 02:48 PM, Ivan Schreter wrote:
>>>> [...]
>>>> Any comments? If nobody vetoes it (Baptiste?, Michael?), I'll probably
>>>> commit it on the weekend.
>>>
>>> The patch is huge and need time for review. Thanks for your
>>> understanding.
>>>
>> Did you have a chance to review the patch?
>>
>> As it only affects seeking on MPEG-TS and seeking results are definitely
>> better than with old seeking implementation in MPEG-TS, I don't see a
>> problem with committing it. Other people are waiting impatiently for
>> this fix.
>>
>> I hope it is OK for you if I commit it and if something comes up in the
>> review, I'll correct it afterwards. I'd like to finally commit it on the
>> weekend.
>
> I understand that people are waiting for the fix, however I don't feel 
> public API should be extended without review. I'm sure other people 
> and especially Michael would like to review it before.
Uhm, this is a misunderstanding. I don't want to extend public API. I 
just fixed the seeking in MPEG-TS streams.

The generic routine I wrote is meant only for demuxers, so that others 
don't have to write it again. Maybe I should put the declaration in 
other header? Which one?

Regards,

Ivan