[FFmpeg-devel] [PATCH] libavfilter-soc: implement pad filter

[Michael Niedermayer]

On Thu, Jul 16, 2009 at 12:49:21AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2009-07-15 01:03:12 +0200, Stefano Sabatini encoded:
> [...]
> > I changed the logic of the patches, now the buffer informations are
> > stored in the link rather than in the params.
> > 
> > This allows for simpler API usage, also makes it possible crop/pad
> > chains which caused troubles before. I'll provide a better explanation
> > with a further patchset, since these ones need to be cleaned up
> > /fixed.
> > 
> > Since the last version:
> > * fixed ffmpeg.c
> > * fixed hflip
> > 
> > Yet to come:
> > * fix vflip
> > * fix for leaks?
> > * add a regression test
> > * direct rendering is not implemented, it would be better to post it
> >   as a separate patchset since this is hard enough
> 
> I added a pix_fmt field to the get_video_buffer, as this information
> is not known in the links (i.e. when configuring the chain).
> 
> Also added a regression test for the pad.
> 
> > I also suspect the exp_w, exp_h, x, y params in the picref are not really
> > required.
> 
> Patches updated.

would it be possible to split that stuff up a little?
(self contained changes with explanations of why its done as is done and
 so on)

that is assuming you want this reviewed ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090716/3b2ca1ba/attachment.pgp>