[FFmpeg-devel] [PATCH] Add SHA-2

[Michael Niedermayer]

On Sun, Jul 12, 2009 at 08:23:29AM +0300, Kostya wrote:
> On Sat, Jul 11, 2009 at 09:13:40PM +0200, Michael Niedermayer wrote:
> > On Fri, Jul 10, 2009 at 06:58:17PM +0300, Kostya wrote:
> > > On Fri, Jul 10, 2009 at 10:48:32AM +0200, Michael Niedermayer wrote:
> > > > On Fri, Jul 10, 2009 at 08:03:52AM +0300, Kostya wrote:
> > > [...]
> > > > > 
> > > > > Here's simple renaming and preparing for future SHA-2.
> > > > >  
> > > > > > [...]
> > > > > > -- 
> > > > > > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > > > 
> > > > >  Makefile |    4 -
> > > > >  sha.c    |   58 ++++++++++++-----
> > > > >  sha.h    |   18 ++---
> > > > >  sha1.c   |  212 ---------------------------------------------------------------
> > > > >  sha1.h   |    3 
> > > > >  5 files changed, 56 insertions(+), 239 deletions(-)
> > > > > 183128e2b269fa450d5637db3674e7b9a1046527  sha-rename.patch
> > > > 
> > > > ok
> > > 
> > > Applied, and here's SHA-2 enhancement.
> > [...]
> > 
> > > +#define ROR32(b,x)  (((x) >> (b)) | ((x) << (32 - (b))))
> > 
> > duplicate of rol()
>  
> dropped
>  

> > > +#define Ch(x,y,z)   (((x) & (y)) ^ ((~(x)) & (z)))
> > > +#define Maj(x,y,z)  (((x) & (y)) ^ ((x) & (z)) ^ ((y) & (z)))
> > 
> > you duplicate optimized code with optimizations removed
> 
> huh?

(w&(x^y))^y

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090714/d7196e3f/attachment.pgp>