[FFmpeg-devel] [PATCH] Fix memory leak in theora encoder

[David Conrad]

On Jul 12, 2009, at 8:38 PM, Art Clarke wrote:

>>
>> Isn't this a bug in libtheora or their documentation? Has it been  
>> reported?
>>
>
> Their doc for the old API (that FFmpeg is using) doesn't explicitly  
> say they
> delete the packet, but can be read to suggest it does.  In reality, it
> doesn't delete the packet.  I don't know if the new Theora API is  
> correctly
> documented and didn't check since FFmpeg doesn't use it.
>
> The original FFmpeg implementor assumed the packet was deleted when  
> the
> comment was deleted.  This is an incorrect assumption.

The documentation says "Clear an allocated theora_comment struct so  
that it can be freed. " so this looks okay, applied.