[FFmpeg-devel] [PATCH] libtheoraenc.c

[David Conrad]

On Jun 30, 2009, at 7:40 AM, j f wrote:

> Hello,
>
> This patch enable quality bitrate management (VBR) in libtheora
> (maped to the "qscale" option, arg value={0-10})
> it also allows the end-user to tune some options of the Theora
> codec like setting a :
> -speed level, this option is maped to the "hurry_up" option, arg
> value={0 | 1 | 2}

hurry_up is depreciated and means something else. At any rate, the  
speed level does nothing in Thusnelda, and for 1.0 it's essentially a  
restricted me_method.

> -threshold for the keyframe autodetection feature, maped to the
> "sc_threshold" option, arg value={0-100}
> -noise reduction level, maped to the "nr" option, arg value={0-6}

These two are gone for good in Thusnelda, and 1.0's quality is bad  
enough that I don't see much gain in tweaking these parameters.

Also, scenechange_threshold is 0 by default, with larger values  
detecting fewer scene changes, so the mapping is wrong for 1.0.

> Index: libavcodec/libtheoraenc.c
> ===================================================================
> --- libavcodec/libtheoraenc.c	(revision 19285)
> +++ libavcodec/libtheoraenc.c	(working copy)
> @@ -47,7 +47,7 @@
>  */
>  static int concatenate_packet(unsigned int* offset, AVCodecContext*  
> avc_context, const ogg_packet* packet)
>  {
> -    char* message = NULL;
> +    const char* message = NULL;

This should be in a separate patch.