[FFmpeg-devel] [PATCH] RTSP-MS 9/15: add interleave property to the TCP transport line of the SETUP request

[Luca Barbato]

Ronald S. Bultje wrote:
> Hi,
> 
> On Tue, Jan 6, 2009 at 3:53 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> Ronald S. Bultje wrote:
>>> On Tue, Jan 6, 2009 at 7:43 AM, Luca Barbato <lu_zero at gentoo.org> wrote:
>>>> Ronald S. Bultje wrote:
>>>>> When choosing TCP as a transport, RTP-compliant servers will
>>>>> automatically select an interleave ID for each stream transmitted over
>>>>> the TCP session. This property can then be used client-side to detect
>>>>> which stream each packet belongs to. Somehow, Microsoft RTSP wants us
>>>>> to request the ID client-side in the SETUP request.
>>>>>
>>>>> This patch adds support for this weird protocol construction...
>>>> Looks ok but
>>>>
>>>>  >                            ";unicast;interleaved=%d-%d",
>>>>
>>>> unicast isn't necessary, defining interleaved is part of the standard
>>>> anyway.
>>> Without unicast it refuses to start here (server replies 461:
>>> unsupported transport protocol).
>>>
>>> If you prefer, I can place the unicast alone under the if (WMS) and
>>> place the interleave outside it so the default RTSP uses it also.
>> Unnecessary doesn't mean wrong, I'd rather have as less special cases as
>> possible.
> 
> OK, RTP accepts with or without unicast, Real only without and WMS
> only with. UDP currently does unicast except for Real, so I added the
> same case for TCP as well. Interleave is supported by all and is thus
> outside of any conditional clause.
> 
> See attached patch, I hope that's OK.

It shouldn't work -> unicast means udp, interleaved means tcp (well any 
other transport in theory but right now just tcp is supported and 
specified in rfcs)

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero