[FFmpeg-devel] [PATCH] Gopher client support

[nazo]

Michael Niedermayer ????????:
> On Sun, Jan 25, 2009 at 01:33:48PM +0900, nazo wrote:
> [...]
>> attached new patch
> 
> [...]
> 
>> +/* used only when posting data */
>> +static int gopher_write(URLContext *h, uint8_t *buf, int size)
>> +{
> 
> comment is not doxygen compatible

I think this is useless comment. just removed.

>> +/**
>> + * Open gopher URI handle via TCP
>> + * @param h media file context
>> + * @param uri of the remote server
>> + * @returns 0 if OK, AVERROR_xxx otherwise
>> + */
>> +static int gopher_open_cnx(URLContext *h, const char *uri)
> 
> this is called just from one point and thus doesnt need to be in its
> own function unless you plan to add some further calls to it in the
> future?
> 
> [...]

sure, merged.

new patch attached.

-- 
Nazo (T.K.) <lovesyao at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gopher.diff
Type: text/x-patch
Size: 5156 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090131/6848a71e/attachment.bin>