[FFmpeg-devel] [PATCH][H264] Record extra fields for VA API support (take 2)

[Gwenolé Beauchesne]

Hi,

Le 31 janv. 09 ? 01:52, Michael Niedermayer a ?crit :

>> @@ -2996,11 +2996,11 @@ static int pred_weight_table(H264Context *h){
>>     chroma_def = 1<<h->chroma_log2_weight_denom;
>>
>>     for(list=0; list<2; list++){
>> +        h->luma_weight_flag[list] = 0;
>> +        h->chroma_weight_flag[list] = 0;
>>         for(i=0; i<h->ref_count[list]; i++){
>> -            int luma_weight_flag, chroma_weight_flag;
>> -
>> -            luma_weight_flag= get_bits1(&s->gb);
>> -            if(luma_weight_flag){
>> +            h->luma_weight_flag[list]= get_bits1(&s->gb);
>> +            if(h->luma_weight_flag[list]){
>>                 h->luma_weight[list][i]= get_se_golomb(&s->gb);
>>                 h->luma_offset[list][i]= get_se_golomb(&s->gb);
>>                 if(   h->luma_weight[list][i] != luma_def
>
> what about setting these flags like use_weight, that is when the
> actual weights are non default?

Do you mean initializing the flags in decode_slice_header() prior to  
calling either pred_weight_table() or implicit_weight_table()? You are  
right, I will fix that.

Regards,
Gwenole.