[FFmpeg-devel] [PATCH] convert to S16 when resampling is requested

[Baptiste Coudurier]

Baptiste Coudurier wrote:
> Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>>> On Fri, Jan 30, 2009 at 02:51:01PM -0800, Baptiste Coudurier wrote:
>>>> Michael Niedermayer wrote:
>>>>> On Fri, Jan 30, 2009 at 12:17:02PM -0800, Baptiste Coudurier wrote:
>>>>>> Hi Michael,
>>>>>>
>>>>>> Michael Niedermayer wrote:
>>>>>>> On Sat, Dec 13, 2008 at 03:53:15PM -0800, Baptiste Coudurier wrote:
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> Michael Niedermayer wrote:
>>>>>>>>> On Fri, Dec 12, 2008 at 12:03:17PM -0800, Baptiste Coudurier
>>>>>>>>> wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> $subject.
>>>>>>>>> I think the audio resampler should support all input & output
>>>>>>>>> sample formats instead. This would be similar to swscale and
>>>>>>>>> would be much easier to use for applications than having these
>>>>>>>>> steps seperated
>>>>>>>> Well, yes, however you suggested that 3 months ago and nobody
>>>>>>>> jumped in to work on it. In the mean time, there is still a big
>>>>>>>> regression in FFmpeg, and I don't see anything fixed in the near
>>>>>>>> future, so this workaround is IMHO acceptable until the most
>>>>>>>> elegant solution is implemented.
>>>>>>> what about moving your solution into the resampler?
>>>>>>>
>>>>>>> I mean, so that one can later replace the X->S16->Y code by something
>>>>>>>  better without having to change the API/ABI
>>>>>> I just looked at it and API does not provide a way to specify input
>>>>>> sample format, so we cannot do this without changing it.
>>>>> Indeed
>>>> So what do you want to do ? Can we still apply the patch on ffmpeg.c ?
>>> if it cant be done without changing API, well
>>> extend it :)
>>>
>>> its just adding a foobar2(samplefmt in / out, ...)
>>> or am i missing something?
>> All right, here it is.
> 
> Humm, old patch sliped in. Here is the good one.

When I screw up, this is serious shit. Last attached patch contained 3
diffs :/

3rd try.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: resample_s16_2.patch
Type: text/x-diff
Size: 9462 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090130/31faf35b/attachment.patch>