[FFmpeg-devel] [PATCH] convert to S16 when resampling is requested

[Baptiste Coudurier]

Hi Michael,

Michael Niedermayer wrote:
> On Sat, Dec 13, 2008 at 03:53:15PM -0800, Baptiste Coudurier wrote:
>> Hi Michael,
>> 
>> Michael Niedermayer wrote:
>>> On Fri, Dec 12, 2008 at 12:03:17PM -0800, Baptiste Coudurier
>>> wrote:
>>>> Hi,
>>>> 
>>>> $subject.
>>> I think the audio resampler should support all input & output
>>> sample formats instead. This would be similar to swscale and
>>> would be much easier to use for applications than having these
>>> steps seperated
>> Well, yes, however you suggested that 3 months ago and nobody
>> jumped in to work on it. In the mean time, there is still a big
>> regression in FFmpeg, and I don't see anything fixed in the near
>> future, so this workaround is IMHO acceptable until the most
>> elegant solution is implemented.
> 
> what about moving your solution into the resampler?
> 
> I mean, so that one can later replace the X->S16->Y code by something
>  better without having to change the API/ABI

I just looked at it and API does not provide a way to specify input
sample format, so we cannot do this without changing it.

Btw, is there something special to deal with when resampling > 2
channels ? Why isn't it supported exactly ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org