[FFmpeg-devel] [PATCH] remove unused and broken test program in libavutil/base64.c

[Baptiste Coudurier]

Hi,

Marc Mason wrote:
> Michael Niedermayer wrote:
> 
>> Stefano Sabatini wrote:
>>
>>>  if (strcmp(encoded, t->encoded) != 0) {
>> superflous != 0
> 
> Redundant (or superfluous) information sometimes make the code or the 
> coder's intention clearer.

Could you please give an example ?
I'm really used to read "!strcmp" to match, and when I don't see the
'!', I know this means "don't match"

In this case, I also think != 0 is redundant and useless.

>>>     printf("\n");
>>>     printf("Encoding/decoding tests on random data\n");
>> can be merged
> 
> For what gain? Cosmetic or computational?

I also find the merge better.

> GCC is likely to merge the two statements.

Does it, or not ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org