[FFmpeg-devel] [PATCH] remove unused and broken test program in libavutil/base64.c

[Stefano Sabatini]

On date Sunday 2009-01-25 10:42:53 +0100, Diego Biurrun encoded:
> On Sat, Jan 24, 2009 at 09:48:16PM +0100, Stefano Sabatini wrote:
> > On date Friday 2009-01-23 09:53:41 +0100, Diego Biurrun encoded:
> > > On Thu, Jan 22, 2009 at 12:09:19AM +0100, Stefano Sabatini wrote:
> > > > On date Thursday 2009-01-22 00:04:13 +0100, Diego Biurrun encoded:
> > > > > I found some more cruft in the attic: a forgotten test program in
> > > > > libavutil/base64.c.  It never compiled, not even the day it was
> > > > > committed, since it calls av_base64_encode() with a wrong number
> > > > > of parameters.
> > > > > 
> > > > > OK to remove?
> > > > 
> > > > Why not to simply fix it?
> > > 
> > > The question is whether it is worth the trouble.  Given that it is
> > > proven that nobody ever used this program, I believe it to be
> > > doubtful that anybody will in the future.
> > > 
> > > Of course you can have a stab at fixing it...
> > 
> > It turned out in a semi-complete rewrite of the test program, anyway I
> > don't feel like to send a patch and discuss every single change, if
> > it's possible to simply replace the new code I'll happily do it.
> > 
> > Follows the new test code:
> > ----------8<--------------------8<--------------------------------
> > //#define TEST
> > #ifdef TEST
> 
> You don't need the #define, just add the file to the TESTS line in
> the Makefile.
> 
> > int main()
> 
> void

Done, let me know if it is OK to apply.

BTW, this is the output of the test program:
Encoding/decoding tests on constant data
Encoding ''... encoded to ''
Decoding ''... decoded to ''
Encoding '1'... encoded to 'MQ=='
Decoding 'MQ=='... decoded to '1'
Encoding '22'... encoded to 'MjI='
Decoding 'MjI='... decoded to '22'
Encoding '333'... encoded to 'MzMz'
Decoding 'MzMz'... decoded to '333'
Encoding '4444'... encoded to 'NDQ0NA=='
Decoding 'NDQ0NA=='... decoded to '4444'
Encoding '55555'... encoded to 'NTU1NTU='
Decoding 'NTU1NTU='... decoded to '55555'
Encoding 'abc:def'... encoded to 'YWJjOmRlZg=='
Decoding 'YWJjOmRlZg=='... decoded to 'abc:def'

Encoding/decoding tests on random data
Test 0: data size 733 bytes... passed!
Test 1: data size 738 bytes... passed!
Test 2: data size 148 bytes... passed!
Test 3: data size 348 bytes... passed!
Test 4: data size 736 bytes... passed!
Test 5: data size 737 bytes... passed!
Test 6: data size 587 bytes... passed!
Test 7: data size 609 bytes... passed!
Test 8: data size 114 bytes... passed!
Test 9: data size 1011 bytes... passed!
Test 10: data size 854 bytes... passed!
Test 11: data size 847 bytes... passed!
Test 12: data size 759 bytes... passed!
Test 13: data size 591 bytes... passed!
Test 14: data size 384 bytes... passed!
Test 15: data size 143 bytes... passed!
Test 16: data size 646 bytes... passed!
Test 17: data size 470 bytes... passed!
Test 18: data size 843 bytes... passed!
Test 19: data size 597 bytes... passed!
Test 20: data size 295 bytes... passed!
Test 21: data size 450 bytes... passed!
Test 22: data size 749 bytes... passed!
Test 23: data size 898 bytes... passed!
Test 24: data size 140 bytes... passed!
Test 25: data size 435 bytes... passed!
Test 26: data size 597 bytes... passed!
Test 27: data size 573 bytes... passed!
Test 28: data size 905 bytes... passed!
Test 29: data size 709 bytes... passed!
Test 30: data size 640 bytes... passed!
Test 31: data size 905 bytes... passed!
Test 32: data size 883 bytes... passed!
Test 33: data size 747 bytes... passed!
Test 34: data size 651 bytes... passed!
Test 35: data size 325 bytes... passed!
Test 36: data size 508 bytes... passed!
Test 37: data size 254 bytes... passed!
Test 38: data size 907 bytes... passed!
Test 39: data size 858 bytes... passed!
Test 40: data size 654 bytes... passed!
Test 41: data size 183 bytes... passed!
Test 42: data size 784 bytes... passed!
Test 43: data size 1002 bytes... passed!
Test 44: data size 569 bytes... passed!
Test 45: data size 505 bytes... passed!
Test 46: data size 281 bytes... passed!
Test 47: data size 773 bytes... passed!
Test 48: data size 842 bytes... passed!
Test 49: data size 664 bytes... passed!
Test 50: data size 827 bytes... passed!
Test 51: data size 537 bytes... passed!
Test 52: data size 791 bytes... passed!
Test 53: data size 22 bytes... passed!
Test 54: data size 461 bytes... passed!
Test 55: data size 799 bytes... passed!
Test 56: data size 533 bytes... passed!
Test 57: data size 602 bytes... passed!
Test 58: data size 631 bytes... passed!
Test 59: data size 836 bytes... passed!
Test 60: data size 604 bytes... passed!
Test 61: data size 632 bytes... passed!
Test 62: data size 494 bytes... passed!
Test 63: data size 836 bytes... passed!
Test 64: data size 838 bytes... passed!
Test 65: data size 967 bytes... passed!
Test 66: data size 594 bytes... passed!
Test 67: data size 271 bytes... passed!
Test 68: data size 326 bytes... passed!
Test 69: data size 154 bytes... passed!
Test 70: data size 99 bytes... passed!
Test 71: data size 691 bytes... passed!
Test 72: data size 347 bytes... passed!
Test 73: data size 193 bytes... passed!
Test 74: data size 211 bytes... passed!
Test 75: data size 906 bytes... passed!
Test 76: data size 476 bytes... passed!
Test 77: data size 980 bytes... passed!
Test 78: data size 277 bytes... passed!
Test 79: data size 466 bytes... passed!
Test 80: data size 682 bytes... passed!
Test 81: data size 173 bytes... passed!
Test 82: data size 1003 bytes... passed!
Test 83: data size 930 bytes... passed!
Test 84: data size 40 bytes... passed!
Test 85: data size 441 bytes... passed!
Test 86: data size 469 bytes... passed!
Test 87: data size 407 bytes... passed!
Test 88: data size 109 bytes... passed!
Test 89: data size 316 bytes... passed!
Test 90: data size 323 bytes... passed!
Test 91: data size 33 bytes... passed!
Test 92: data size 234 bytes... passed!
Test 93: data size 88 bytes... passed!
Test 94: data size 420 bytes... passed!
Test 95: data size 731 bytes... passed!
Test 96: data size 572 bytes... passed!
Test 97: data size 446 bytes... passed!
Test 98: data size 173 bytes... passed!
Test 99: data size 4 bytes... passed!

Encoding/decoding tests on constant with an invalid termination data
Checking for validity of invalid encoded sequence 'M'... considered valid, test failed!
Checking for validity of invalid encoded sequence 'M=M='... considered valid, test failed!
Checking for validity of invalid encoded sequence 'MQ==='... considered valid, test failed!

Regards.
-- 
FFmpeg = Freak and Free Mega Peaceful Elastic Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: base64-test-rewrite-00.patch
Type: text/x-diff
Size: 7998 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090126/35aca553/attachment.patch>